iishitahere commented on issue #10007: URL: https://github.com/apache/cloudstack/issues/10007#issuecomment-2526210158
> > Hi @DaanHoogland , > > I hope this message finds you well. I apologize for the delay in submitting this fix; I was one day late due to unforeseen circumstances. Thank you for your patience. > > Regarding the issue, I’ve made the following changes in the VmwareTrafficLabel class to resolve the inconsistent bandwidth allocation for secondary NICs in VMware L2 networks: > > Traffic Label Parsing Enhancement: Updated the _parseLabel method to ensure consistent interpretation of the traffic label, irrespective of NIC type. Default Values Adjustment: Ensured that both the default NIC and secondary NICs adhere to the same bandwidth specifications derived from the network offering or global throttling settings. Error Handling Improvement: Added checks to validate and handle unexpected or invalid traffic label fields gracefully, reducing potential misconfigurations. Code Cleanup: Simplified logic and ensured compliance with the project's coding standards for better readability and maintainability. These changes aim to align the bandwidth configuration across all NICs of a VM, as per the expected behavior described in the issue report. I have tested the changes locally to verify their correctness. > > Please let me know if there’s anything else I need to address or refine. I look forward to your feedback and further guidance. > > Thank you again for your time and support! > > Best regards, Ishita Jaiswal > > hi @iishitahere (Ishita), > > this works sounds awesome, but we deal (communicate largely through code and/or illustrated by code. Can I ask you to submit a PR and discuss the changes there? > > You do not have to apologise for anything. We do not expect things and everything is a bonus. We are very glad that you are willing to work on the codebase. regards, Hi @DaanHoogland, Thank you for your kind words and encouragement! I truly appreciate your approach and the welcoming environment you've created. I’ve already submitted the PR for the changes. Please feel free to review it, and let me know if there’s anything I can improve or clarify. I’m happy to make adjustments based on your feedback. Looking forward to collaborating further! Best regards, Ishita -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
