iishitahere commented on PR #10060: URL: https://github.com/apache/cloudstack/pull/10060#issuecomment-2527510679
> @iishitahere , it looks like you did not commit all your changes, as there is only one file submitted. Also it looks like you are new to using git/github as you submitted a PR from your main branch instead of a new branch. Please reach out if you need more help. > > > Changes: Fixed the traffic shaping functionality for secondary NICs in VmwareTrafficLabel. > > This ^ is the only change that seems to be there. > > > Updated configurations to ensure traffic shaping is applied consistently across all NICs. Testing: Verified the fix by testing traffic shaping on VMware setups with multiple NICs, ensuring secondary NICs are properly shaped without affecting primary NICs. > > These ^ changes are missing. Hi @DaanHoogland, Thank you for your feedback and for pointing out the issues. About the missing changes: I understand the concern. It seems I may have missed committing all the necessary files or changes. I will review my local repository, commit the remaining updates, and push them to this PR shortly. Branching: You are correct that I used the main branch for this PR. I appreciate the guidance on best practices and will create a dedicated branch for any future contributions. Thank you again for your help! I'll address these issues promptly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
