iishitahere commented on PR #10060: URL: https://github.com/apache/cloudstack/pull/10060#issuecomment-2536036721
Hi @DaanHoogland, Thank you for your valuable feedback and for highlighting the issues in my PR. I truly appreciate the guidance and patience. Updates I Will Make: Committing Missing Changes: I will review my local repository to ensure all necessary changes, including updated configurations and related code, are committed. This will include updates ensuring consistent traffic shaping across all NICs and any related testing code. Branching Best Practices: I acknowledge submitting the PR from the main branch was not ideal. Moving forward, I will create a dedicated branch for each feature or fix. Addressing Unused Method: I will verify the relevance of the isTrafficShapingConsistent() method and remove it if unnecessary. I plan to update the PR with these changes by 13/12/2024. Could you confirm if there are specific configurations or tests you'd like me to prioritize? Additionally, should I include specific documentation or test cases to validate these updates? Thank you again for your guidance, and I’ll ensure future contributions adhere to project standards. Best regards, Ishita -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
