iishitahere commented on PR #10060: URL: https://github.com/apache/cloudstack/pull/10060#issuecomment-2566309302
> @iishitahere , I welcome your enthausiasm in contributing but you now have three PRs open, this, #10134 and #10109. All of them seem to be missing code. I think you need to look at your git repos to see how and where changes got lost. In addition to that, can you reference the issue you solve in the PRs? There is a placeholder in the default description text for that. You can uncomment it and add the respective issue numbers. Hi @DaanHoogland, Thank you for your feedback, and I apologize for the confusion caused by the missing code. I’ve now fixed the missing code and pushed the latest changes, ensuring consistent traffic shaping across all NICs. I’ve also removed the unused isTrafficShapingConsistent() method to simplify the code. The issue reference has been added to the PR description: Fixes #10007. Please review the changes and let me know if there are any further concerns or adjustments needed! Best regards, Ishita -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
