DaanHoogland commented on code in PR #10264:
URL: https://github.com/apache/cloudstack/pull/10264#discussion_r1930479516
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##########
@@ -586,11 +586,11 @@ protected AgentAttache notifyMonitorsOfConnection(final
AgentAttache attache, fi
}
} catch (final HypervisorVersionChangedException hvce) {
handleDisconnectWithoutInvestigation(attache,
Event.ShutdownRequested, true, true);
- throw new CloudRuntimeException("Unable to connect " +
attache.getId(), hvce);
+ throw new CloudRuntimeException("Unable to connect " +
(attache == null ? "<unknown agent>" : attache.getId()), hvce);
Review Comment:
I would not mind , but don't see that this improves robustness or
readability @hsato03 . What is your intention/sugestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
