hsato03 commented on code in PR #10264:
URL: https://github.com/apache/cloudstack/pull/10264#discussion_r1930496749
##########
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java:
##########
@@ -586,11 +586,11 @@ protected AgentAttache notifyMonitorsOfConnection(final
AgentAttache attache, fi
}
} catch (final HypervisorVersionChangedException hvce) {
handleDisconnectWithoutInvestigation(attache,
Event.ShutdownRequested, true, true);
- throw new CloudRuntimeException("Unable to connect " +
attache.getId(), hvce);
+ throw new CloudRuntimeException("Unable to connect " +
(attache == null ? "<unknown agent>" : attache.getId()), hvce);
Review Comment:
@DaanHoogland the intention was to improve readability, but after reading
the code again I realized that the method would not be useful in this
situation. Please ignore my suggestion 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
