erickalendra commented on code in PR #10686:
URL: https://github.com/apache/cloudstack/pull/10686#discussion_r2037760585
##########
server/src/test/java/com/cloud/network/NetworkServiceImplTest.java:
##########
@@ -141,11 +146,11 @@ public class NetworkServiceImplTest {
@Mock
VpcManager vpcMgr;
@Mock
- NetworkOrchestrationService networkManager;
+ NetworkOrchestrationService _networkMgr;
@Mock
AlertManager alertManager;
@Mock
- DataCenterDao dcDao;
+ DataCenterDao _dcDao;
Review Comment:
The changes with the "_" are required for the "@InjectMocks" to function due
to how Mockito is doing field matching. The naming convention needs to match
the fields of the Classes that are getting injected. Updating the naming
convention of the classes getting tested is unrelated to updating the Mockito
version, and I feel that should be debated independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
