erickalendra commented on code in PR #10686:
URL: https://github.com/apache/cloudstack/pull/10686#discussion_r2037813974
##########
server/src/test/java/com/cloud/network/NetworkServiceImplTest.java:
##########
@@ -141,11 +146,11 @@ public class NetworkServiceImplTest {
@Mock
VpcManager vpcMgr;
@Mock
- NetworkOrchestrationService networkManager;
+ NetworkOrchestrationService _networkMgr;
@Mock
AlertManager alertManager;
@Mock
- DataCenterDao dcDao;
+ DataCenterDao _dcDao;
Review Comment:
@JoaoJandre I agree about Java style and naming. However, I am unable to
have Mockito 5 inject the mocks without making the field names match. This is
due to multiple mocks being created with the same type. In the class:
```
@Mock
DataCenterDao dataCenterDao;
...
@Mock
DataCenterDao _dcDao;
```
@JoaoJandre Could you accept the changes in naming due to them being
required for Mockito 5 mock injection to function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
