weizhouapache commented on code in PR #10696:
URL: https://github.com/apache/cloudstack/pull/10696#discussion_r2039239311
##########
api/src/main/java/com/cloud/deploy/DeploymentClusterPlanner.java:
##########
@@ -62,7 +62,7 @@ public interface DeploymentClusterPlanner extends
DeploymentPlanner {
"vm.allocation.algorithm",
"Advanced",
"random",
- "Order in which hosts within a cluster will be considered for
VM/volume allocation. The value can be 'random', 'firstfit', 'userdispersing',
'userconcentratedpod_random', 'userconcentratedpod_firstfit', or
'firstfitleastconsumed'.",
+ "Order in which hosts within a cluster will be considered for VM
allocation. The value can be 'random', 'firstfit', 'userdispersing',
'userconcentratedpod_random', 'userconcentratedpod_firstfit', or
'firstfitleastconsumed'.",
true,
Review Comment:
I think we do not need to initialize the value in `configure` method
instead, we can get the value from DB before using it, then the setting
becomes dynamic which is more flexible for users (no need to restart mgmt
server)
"vm.allocation.algorithm" can be changed to dynamic too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
