sudo87 commented on code in PR #10696:
URL: https://github.com/apache/cloudstack/pull/10696#discussion_r2039297583
##########
api/src/main/java/com/cloud/deploy/DeploymentClusterPlanner.java:
##########
@@ -62,7 +62,7 @@ public interface DeploymentClusterPlanner extends
DeploymentPlanner {
"vm.allocation.algorithm",
"Advanced",
"random",
- "Order in which hosts within a cluster will be considered for
VM/volume allocation. The value can be 'random', 'firstfit', 'userdispersing',
'userconcentratedpod_random', 'userconcentratedpod_firstfit', or
'firstfitleastconsumed'.",
+ "Order in which hosts within a cluster will be considered for VM
allocation. The value can be 'random', 'firstfit', 'userdispersing',
'userconcentratedpod_random', 'userconcentratedpod_firstfit', or
'firstfitleastconsumed'.",
true,
Review Comment:
Looks like Admin restarts mgmt server everytime "vm.allocation.algorithm" is
updated. This is usual behavior for them.
@weizhouapache shall I modify implementation to fetch value at the time of
usage for both configuration: vm.allocation.algorithm and
volume.allocation.algorithm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
