sudo87 commented on code in PR #10696:
URL: https://github.com/apache/cloudstack/pull/10696#discussion_r2041685566
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java:
##########
@@ -209,7 +204,7 @@ public List<StoragePool> reorderPools(List<StoragePool>
pools, VirtualMachinePro
account = vmProfile.getOwner();
}
- pools = reorderStoragePoolsBasedOnAlgorithm(pools, plan, account);
+ pools = reorderStoragePoolsBasedOnAlgorithm(pools, plan, account,
VolumeOrchestrationService.VolumeAllocationAlgorithm.value());
Review Comment:
This change is done to allow existing unit tests to work with different
algorithms.
Other way was to mock configkey. To achieve that we have to declare and
define: VolumeAllocationAlgorithm in VolumeOrchestrator and it was causing
cyclic dependency during import in AbstractStoragePoolAllocatorTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
