weizhouapache commented on PR #10696:
URL: https://github.com/apache/cloudstack/pull/10696#issuecomment-2805004962

   code lgtm
   
   However, I think we need to think of the upgrade
   for example, now the vm/volume allocation algorithm is set to `firstfit`, 
when uprgade to a new version with this PR, the vm allocation algorithm is 
still `firstfit`, but volume allocation algorithm will be the default value 
`random`.
   
   @sudo87 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to