DaanHoogland commented on code in PR #9752:
URL: https://github.com/apache/cloudstack/pull/9752#discussion_r2182600360
##########
api/src/main/java/com/cloud/agent/api/Command.java:
##########
@@ -60,6 +61,7 @@ public enum State {
private int wait; //in second
private boolean bypassHostMaintenance = false;
private transient long requestSequence = 0L;
+ protected Map<String, Map<String, String>> externalDetails;
Review Comment:
Is there a reason these should be called `externalDetails`, and not just
`details`?
##########
api/src/main/java/com/cloud/network/NetworkService.java:
##########
@@ -270,4 +270,6 @@ Network createPrivateNetwork(String networkName, String
displayText, long physic
List<InternalLoadBalancerElementService> getInternalLoadBalancerElements();
boolean handleCksIsoOnNetworkVirtualRouter(Long virtualRouterId, boolean
mount) throws ResourceUnavailableException;
+
+ String getNsxSegmentId(long domainId, long accountId, long zoneId, Long
vpcId, long networkId);
Review Comment:
is this a rebase issue? seems unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
