shwstppr commented on code in PR #9752:
URL: https://github.com/apache/cloudstack/pull/9752#discussion_r2184390898


##########
api/src/main/java/com/cloud/network/NetworkService.java:
##########
@@ -270,4 +270,6 @@ Network createPrivateNetwork(String networkName, String 
displayText, long physic
     List<InternalLoadBalancerElementService> getInternalLoadBalancerElements();
 
     boolean handleCksIsoOnNetworkVirtualRouter(Long virtualRouterId, boolean 
mount) throws ResourceUnavailableException;
+
+    String getNsxSegmentId(long domainId, long accountId, long zoneId, Long 
vpcId, long networkId);

Review Comment:
   Maybe @harikrishna-patnala can give some insight on this. Probably idea is 
to get a VLAN ID equivalent identifier from SDNs and it should come from that 
SDN plugin instead defining it in NetworkService. I'll have a look



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to