DaanHoogland commented on code in PR #11773:
URL: https://github.com/apache/cloudstack/pull/11773#discussion_r2401302150
##########
server/src/main/java/com/cloud/storage/StoragePoolAutomationImpl.java:
##########
@@ -346,6 +346,11 @@ public boolean cancelMaintain(DataStore store) {
if (logger.isDebugEnabled()) {
logger.debug("ModifyStoragePool add succeeded");
}
+ try {
+ storageManager.connectHostToSharedPool(host, pool.getId());
+ } catch (Exception e) {
+ logger.warn("Unable to establish a connection between {}
and {}", host, pool, e);
+ }
Review Comment:
what if the third of six hosts fails? what would the state of the overall
system be at that point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
