bradh352 commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2579095320
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,13 @@ public String getMemBalloonStatsPeriod() {
@Override
public String toString() {
StringBuilder memBalloonBuilder = new StringBuilder();
- memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'>\n");
+ memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'");
+ /* Version integer format: major * 1,000,000 + minor * 1,000 +
release.
+ * Require: libvirt 6.9.0, qemu 5.1.0 */
+ if (memBalloonModel != MemBalloonModel.NONE && s_qemuVersion >=
5001000 && s_libvirtVersion >= 6009000) {
Review Comment:
@bernardodemarco I'm unfortunately not familiar with the specifics of
javadoc so its not clear to me how to apply this to something other than a
method itself. I can update it if you let me know how it needs to be formatted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
