bernardodemarco commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2481556630
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,13 @@ public String getMemBalloonStatsPeriod() {
@Override
public String toString() {
StringBuilder memBalloonBuilder = new StringBuilder();
- memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'>\n");
+ memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'");
+ /* Version integer format: major * 1,000,000 + minor * 1,000 +
release.
+ * Require: libvirt 6.9.0, qemu 5.1.0 */
+ if (memBalloonModel != MemBalloonModel.NONE && s_qemuVersion >=
5001000 && s_libvirtVersion >= 6009000) {
Review Comment:
@bradh352, thanks for the PR, code looks good. Just one minor suggestion,
could you extract this comment into a method's Javadoc string? For instance:
https://github.com/apache/cloudstack/blob/3d6cafe1936ed2403a1031cd5ad42dd205934412/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L2178-L2183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
