bradh352 commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2475679563
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
@Override
public String toString() {
StringBuilder memBalloonBuilder = new StringBuilder();
- memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'>\n");
+ memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'");
+ if (memBalloonModel != MemBalloonModel.NONE) {
Review Comment:
Ok, I added the version checks. Btw, I see some version checks using the
wrong format in the code during a grep:
```
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:1641:
&& s_qemuVersion >= 4200000 && s_libvirtVersion >=
6300000;
```
Those would resolve to 4.200.0 and 6.300.0. Should probably provide version
helpers for checks to prevent errors like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
