winterhazel commented on code in PR #12571:
URL: https://github.com/apache/cloudstack/pull/12571#discussion_r2758769073
##########
engine/components-api/src/main/java/com/cloud/agent/AgentManager.java:
##########
@@ -54,6 +54,9 @@ public interface AgentManager {
"This timeout overrides the wait global config. This holds a comma
separated key value pairs containing timeout (in seconds) for specific
commands. " +
"For example: DhcpEntryCommand=600,
SavePasswordCommand=300, VmDataCommand=300", false);
+ ConfigKey<Integer> KVMHostDiscoverySshPort = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Integer.class,
Review Comment:
Wouldn't it be better to have this as a parameter on host addition to allow
configuring it on a host-level?
##########
engine/components-api/src/main/java/com/cloud/agent/AgentManager.java:
##########
@@ -54,6 +54,9 @@ public interface AgentManager {
"This timeout overrides the wait global config. This holds a comma
separated key value pairs containing timeout (in seconds) for specific
commands. " +
"For example: DhcpEntryCommand=600,
SavePasswordCommand=300, VmDataCommand=300", false);
+ ConfigKey<Integer> KVMHostDiscoverySshPort = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Integer.class,
Review Comment:
Wouldn't it be better to have this as a parameter on host addition/edit to
allow configuring it on a host-level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
