sureshanaparti commented on code in PR #12571:
URL: https://github.com/apache/cloudstack/pull/12571#discussion_r2762665756
##########
engine/components-api/src/main/java/com/cloud/agent/AgentManager.java:
##########
@@ -54,6 +54,9 @@ public interface AgentManager {
"This timeout overrides the wait global config. This holds a comma
separated key value pairs containing timeout (in seconds) for specific
commands. " +
"For example: DhcpEntryCommand=600,
SavePasswordCommand=300, VmDataCommand=300", false);
+ ConfigKey<Integer> KVMHostDiscoverySshPort = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Integer.class,
Review Comment:
the config is applicable for the kvm hosts on the entire cloudstack
installation, mainly for large deployments where the custom port is used for
all the hosts. it doesn't provide flexibility to set few hosts on one port, and
few hosts on the other. it's always better to have all these hosts accessible
on the same port. a new host parameter (that can be updated through add or
update host call) can provide flexibility, but it's mostly NULL/empty (when not
defined or default port is used) and is not applicable for VMware hosts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
