sureshanaparti commented on code in PR #12970:
URL: https://github.com/apache/cloudstack/pull/12970#discussion_r3049438941
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -1662,9 +1668,16 @@ protected UserVm
importUnmanagedInstanceFromVmwareToKvm(DataCenter zone, Cluster
}
checkConversionStoragePool(convertStoragePoolId, forceConvertToPool);
+ validateSelectedConversionStoragePoolForVddk(useVddk,
convertStoragePoolId, serviceOffering, dataDiskOfferingMap);
checkExtraParamsAllowed(extraParams);
+ if (forceMsToImportVmFiles && useVddk) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR,
+ String.format("Parameters %s and %s are mutually
exclusive",
+ ApiConstants.FORCE_MS_TO_IMPORT_VM_FILES,
ApiConstants.USE_VDDK));
+ }
Review Comment:
can move this validation before checking for pool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
