sureshanaparti commented on code in PR #12970:
URL: https://github.com/apache/cloudstack/pull/12970#discussion_r3049461188


##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -1730,7 +1743,7 @@ protected UserVm 
importUnmanagedInstanceFromVmwareToKvm(DataCenter zone, Cluster
                 convertedInstance = 
convertVmwareInstanceToKVMAfterExportingOVFToConvertLocation(

Review Comment:
   check if we can have separate methods for conversion using vddk and export 
ovf on kvm host
   
   otherwise, change method name
   
   ```suggestion
                   convertedInstance = 
convertVmwareInstanceToKVMUsingVDDKOrAfterExportingOVFToConvertLocation(
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to