bernardodemarco commented on code in PR #13015:
URL: https://github.com/apache/cloudstack/pull/13015#discussion_r3268531674
##########
engine/schema/src/main/resources/META-INF/db/schema-42210to42300.sql:
##########
@@ -117,3 +117,21 @@ CALL
`cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vpc_offerings','conserve_mode', 'tin
--- Disable/enable NICs
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.nics','enabled', 'TINYINT(1) NOT
NULL DEFAULT 1 COMMENT ''Indicates whether the NIC is enabled or not'' ');
+
+-- Soft delete port forwarding, load balancing and firewall rules
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.firewall_rules', 'removed',
'datetime DEFAULT NULL');
Review Comment:
@weizhouapache, thanks for your review!
Regarding the tables `firewall_rules`, `load_balancer_vm_map`,
`load_balancer_cert_map`, `load_balancer_healthcheck_policies`, and
`load_balancer_stickiness_policies`, we should keep the `removed` column to
preserve a complete overview of the LB, FW and PF metadata.
However, for the tables `global_load_balancer_lb_rule_map`,
`elastic_lb_vm_map`, `tungsten_lb_health_monitor`, and
`global_load_balancing_rules`, I believe they are related to legacy ACS
features. Personally, I have never seen them being used. I added the `removed`
column to maintain consistency with the existing standard/pattern, but I can
remove these changes if you think that would be preferable. Let me know your
thoughts on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
