bernardodemarco commented on code in PR #13015:
URL: https://github.com/apache/cloudstack/pull/13015#discussion_r3276743294
##########
engine/schema/src/main/resources/META-INF/db/schema-42210to42300.sql:
##########
@@ -117,3 +117,21 @@ CALL
`cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vpc_offerings','conserve_mode', 'tin
--- Disable/enable NICs
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.nics','enabled', 'TINYINT(1) NOT
NULL DEFAULT 1 COMMENT ''Indicates whether the NIC is enabled or not'' ');
+
+-- Soft delete port forwarding, load balancing and firewall rules
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.firewall_rules', 'removed',
'datetime DEFAULT NULL');
Review Comment:
> As you can see, several DAO/VO/Impl classes need to be reviewed and
updated accordingly.
@weizhouapache, yes, exactly. Before submitting the PR, I had already
reviewed these classes and layers. Additionally, I have been running this patch
in production for about 10 months, and no regressions have been identified so
far.
It took me some time to open the PR because I wanted to ensure that it would
not introduce any major regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
