bernardodemarco commented on PR #13015: URL: https://github.com/apache/cloudstack/pull/13015#issuecomment-4490679684
> maybe I am missing something @bernardodemarco . If we “only” mark as removed, should we add some garbage collection? @DaanHoogland, yes, we could. Currently, almost every delete/remove API in ACS only marks resources as removed instead of expunging them from the DB. I personally prefer this approach because, in recovery scenarios, it makes it much easier to retrieve the desired metadata. Additionally, the core idea of the current PR is to keep PF, LB and FW metadata in the DB after their removal, enabling cloud providers to properly investigate and analyze users' past network usage. Therefore, specially for these resources, it is even more important to not expunge them. If desired, one viable approach would be to extend the `purgeExpungedResources` API to also encompass the expunging of such networking rules. Let me know what you think about this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
