Copilot commented on code in PR #13602: URL: https://github.com/apache/cloudstack/pull/13602#discussion_r3573739299
########## debian/cloudstack-common.postinst: ########## @@ -22,11 +22,11 @@ CLOUDUTILS_DIR="/usr/share/pyshared/" DIST_DIR=$(python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))") if which pycompile >/dev/null 2>&1; then - pycompile -p cloudstack-common + pycompile -p cloudstack-common || true Review Comment: `|| true` suppresses all `pycompile` failures silently, which can hide real packaging/install problems and make troubleshooting difficult. If the intent is to keep installation going, at least emit a warning to stderr when compilation fails. ########## debian/cloudstack-common.postinst: ########## @@ -22,11 +22,11 @@ CLOUDUTILS_DIR="/usr/share/pyshared/" DIST_DIR=$(python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))") if which pycompile >/dev/null 2>&1; then - pycompile -p cloudstack-common + pycompile -p cloudstack-common || true fi if which pycompile >/dev/null 2>&1; then - pycompile -p cloudstack-common /usr/share/cloudstack-common + pycompile -p cloudstack-common /usr/share/cloudstack-common || true Review Comment: This ignores `pycompile` errors without any diagnostic output. If `pycompile` is flaky on some Debian/Python combinations, consider keeping the non-fatal behavior but logging a warning so failures are visible in dpkg logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
