Copilot commented on code in PR #13602: URL: https://github.com/apache/cloudstack/pull/13602#discussion_r3576919822
########## debian/cloudstack-common.postinst: ########## @@ -22,11 +22,11 @@ CLOUDUTILS_DIR="/usr/share/pyshared/" DIST_DIR=$(python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))") if which pycompile >/dev/null 2>&1; then - pycompile -p cloudstack-common + pycompile -p cloudstack-common || echo "Warning: pycompile failed for cloudstack-common" >&2 fi Review Comment: Using `which` in maintainer scripts is not POSIX and can be missing in minimal environments; prefer `command -v` (a shell builtin). Since the `pycompile` check is duplicated, you can also collapse both blocks into a single `if` and run both `pycompile` commands inside it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
