GaOrtiga opened a new pull request, #13789: URL: https://github.com/apache/cloudstack/pull/13789
### Description When a backup fails because connection with the VM's guest agent failed, the VM remains consistent, therefore, there is no need to place it in the `BackupError` state. This validation, however is done by verifying the error message sent by Libvirt, which can be different on older versions. It also does not cover every case of Guest Agent connection failures, as Libvirt's code contains multiple places where this error is thrown, with different messages. This PR changes this validation to use the errors # (ordinal) instead of the message, to avoid these issues. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? I disabled the Guest Agent on the VM and tried creating a backup, and verified that the backup failed but the VM was no placed in the `BackupError` state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
