GaOrtiga commented on code in PR #13789:
URL: https://github.com/apache/cloudstack/pull/13789#discussion_r3729318326
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -7185,7 +7185,7 @@ public Map<String, Long>
createDiskOnlyVmSnapshotForRunningVm(List<Pair<VolumeOb
} catch (LibvirtException e) {
String errorMsg = String.format("Creation of disk-only VM snapshot
for VM [%s] failed due to %s.", vmName, e.getMessage());
boolean isVmConsistent = false;
- if (e.getMessage().contains(AGENT_IS_NOT_CONNECTED)) {
+ if
(AGENT_UNRESPONSIVE_ERROR_ORDINAL.equals(e.getError().getCode().ordinal())) {
Review Comment:
Done
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtValidateKbossVmCommandWrapper.java:
##########
@@ -92,7 +92,7 @@ private boolean waitForBoot(ValidateKbossVmCommand cmd,
Domain vm) throws Libvir
return true;
}
} catch (LibvirtException ex) {
- if
(!ex.getMessage().contains(LibvirtComputingResource.AGENT_IS_NOT_CONNECTED)) {
+ if
(!LibvirtComputingResource.AGENT_UNRESPONSIVE_ERROR_ORDINAL.equals(ex.getError().getCode().ordinal()))
{
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
