harikrishna-patnala commented on code in PR #13677:
URL: https://github.com/apache/cloudstack/pull/13677#discussion_r3949373398
##########
server/src/main/java/com/cloud/api/ApiServlet.java:
##########
@@ -78,7 +79,19 @@ public class ApiServlet extends HttpServlet {
protected static Logger LOGGER = LogManager.getLogger(ApiServlet.class);
private static final Logger ACCESSLOGGER =
LogManager.getLogger("apiserver." + ApiServlet.class.getName());
private static final String REPLACEMENT = "_";
- private static final String LOGGER_REPLACEMENTS = "[\n\r\t]";
+private static final String REDACTED = "REDACTED";
+private static final String LOGGER_REPLACEMENTS = "[\n\r\t]";
+
+private static final Set<String> SENSITIVE_PARAMETER_KEYWORDS = Set.of(
Review Comment:
https://github.com/apache/cloudstack/blob/02182a1572a12a89fc2f429f57bcec6f9e6ad7c0/server/src/main/java/com/cloud/api/ApiServer.java#L554-L559
@dheeraj12347 there is another place with the same content exists and there
it has already addressed with "cleanString()" method, which doesnot cover all
the sensitive parameters you have listed. Can you please check if this can be
fixed somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
