harikrishna-patnala commented on code in PR #13677:
URL: https://github.com/apache/cloudstack/pull/13677#discussion_r3954967271
##########
server/src/main/java/com/cloud/api/ApiServlet.java:
##########
@@ -78,7 +79,19 @@ public class ApiServlet extends HttpServlet {
protected static Logger LOGGER = LogManager.getLogger(ApiServlet.class);
private static final Logger ACCESSLOGGER =
LogManager.getLogger("apiserver." + ApiServlet.class.getName());
private static final String REPLACEMENT = "_";
- private static final String LOGGER_REPLACEMENTS = "[\n\r\t]";
+private static final String REDACTED = "REDACTED";
+private static final String LOGGER_REPLACEMENTS = "[\n\r\t]";
+
+private static final Set<String> SENSITIVE_PARAMETER_KEYWORDS = Set.of(
Review Comment:
thanks for the changes @dheeraj12347. I've tested it looks good from logic
and logs point of view.
`2026-09-08 06:25:35,022 WARN [c.c.a.ApiServlet]
(qtp1404565079-346:[ctx-92464837]) (logid:4df39a1d) Query parameter 'password'
has multiple values [REDACTED, REDACTED]. Only the last value will be
respected.It is advised to pass only a single parameter`
Can you please move these helper methods to StringUtils class ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
