dheeraj12347 commented on code in PR #13677:
URL: https://github.com/apache/cloudstack/pull/13677#discussion_r3953744313
##########
server/src/main/java/com/cloud/api/ApiServlet.java:
##########
@@ -78,7 +79,19 @@ public class ApiServlet extends HttpServlet {
protected static Logger LOGGER = LogManager.getLogger(ApiServlet.class);
private static final Logger ACCESSLOGGER =
LogManager.getLogger("apiserver." + ApiServlet.class.getName());
private static final String REPLACEMENT = "_";
- private static final String LOGGER_REPLACEMENTS = "[\n\r\t]";
+private static final String REDACTED = "REDACTED";
+private static final String LOGGER_REPLACEMENTS = "[\n\r\t]";
+
+private static final Set<String> SENSITIVE_PARAMETER_KEYWORDS = Set.of(
Review Comment:
@harikrishna-patnala Addressed this by using
ApiServlet.formatValuesForLog() in the ApiServer duplicate-parameter warning,
so the same sensitive-parameter redaction is applied there as well. The
existing cleanString() sanitization is still retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
