nagaboinaramgopal opened a new pull request, #14106: URL: https://github.com/apache/cloudstack/pull/14106
### Description An internal LB VM runs only the load balancer, but it is configured with the full virtual router health check set. The dhcp and dns checks have nothing to verify on an internal LB, so they fail on every advanced health check run and flood the event log with failures every few minutes. This excludes the dhcp and dns checks for a router whose role is internal LB, using the existing per-router excluded-checks mechanism (the same one that already excludes the gateway check on backup routers). Fixes: #12658 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [x] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): N/A ### How Has This Been Tested? Added a unit test on createMonitorServiceCommand: for a router whose role is internal LB, the excluded health checks now include dhcp_check.py and dns_check.py. Before this change the excluded set is empty for that router and the test fails. The existing appliance-manager tests still pass. #### How did you try to break this feature and the system with this change? The exclusion is gated on the internal LB role, so a normal virtual router or VPC router is unaffected. The change only appends to the existing excluded-checks list, alongside the backup-router gateway-check exclusion that is already there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
