sudo87 commented on code in PR #13325:
URL: https://github.com/apache/cloudstack/pull/13325#discussion_r4186677160


##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -777,6 +777,11 @@ private void updateRouterIpInNetworkDetails(Long 
networkId, String routerIp, Str
         }
     }
 
+    private void saveNetworkRateInDetails(long networkId, NetworkOffering 
offering, long dataCenterId) {
+        Integer rate = 
_configMgr.getNetworkOfferingNetworkRate(offering.getId(), dataCenterId);
+        networkDetailsDao.addDetail(networkId, ApiConstants.NETWORKRATE, 
String.valueOf(rate), true);

Review Comment:
   copyNetworkDetails now skips networkrate. The copy keeps the old offering's 
rate and the migrated network updates it when it moves to the new offering, so 
one row is left (checked on KVM with migrateNetwork and migrateVPC).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to