sudo87 commented on code in PR #13325:
URL: https://github.com/apache/cloudstack/pull/13325#discussion_r4186865515
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -2715,6 +2720,9 @@ public NetworkResponse createNetworkResponse(ResponseView
view, Network network)
response.setNetworkDomain(network.getNetworkDomain());
response.setPublicMtu(network.getPublicMtu());
response.setPrivateMtu(network.getPrivateMtu());
+ NetworkDetailVO networkRateDetail =
networkDetailsDao.findDetail(network.getId(), ApiConstants.NETWORKRATE);
+ int networkRate = networkRateDetail != null ?
NumberUtils.toInt(networkRateDetail.getValue(), -1) : -1;
+ response.setNetworkRate(networkRate > 0 ? networkRate : -1);
Review Comment:
improved this slightily for root-admin as details are preloaded.
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -2715,6 +2720,9 @@ public NetworkResponse createNetworkResponse(ResponseView
view, Network network)
response.setNetworkDomain(network.getNetworkDomain());
response.setPublicMtu(network.getPublicMtu());
response.setPrivateMtu(network.getPrivateMtu());
+ NetworkDetailVO networkRateDetail =
networkDetailsDao.findDetail(network.getId(), ApiConstants.NETWORKRATE);
+ int networkRate = networkRateDetail != null ?
NumberUtils.toInt(networkRateDetail.getValue(), -1) : -1;
+ response.setNetworkRate(networkRate > 0 ? networkRate : -1);
Review Comment:
improved this slightly for root-admin as details are preloaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
