weizhouapache commented on code in PR #14073:
URL: https://github.com/apache/cloudstack/pull/14073#discussion_r4195034356
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -5042,8 +5043,10 @@ private Long getDeviceId(UserVmVO vm, Long deviceId) {
int maxDevices = getMaxDataVolumesSupported(vm) + 2; // add 2 to
consider devices root volume and cdrom
int maxDeviceId = maxDevices - 1;
List<VolumeVO> vols = _volsDao.findByInstance(vm.getId());
+ boolean vmHasConfigDrive = vmInstanceDetailsDao.findDetail(vm.getId(),
VmDetailConstants.CONFIG_DRIVE_LOCATION) != null;
Review Comment:
good point. I did not consider this case.
maybe we need to determine if configdrive ISO is needed by the
network/offering providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
