weizhouapache commented on code in PR #14073:
URL: https://github.com/apache/cloudstack/pull/14073#discussion_r4195396665
##########
server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java:
##########
@@ -142,7 +142,7 @@ public class ConfigDriveNetworkElement extends AdapterBase
implements NetworkEle
@Inject
private HypervisorGuruManager _hvGuruMgr;
- private final static Integer CONFIGDRIVEDISKSEQ = 4;
+ public static final Integer CONFIGDRIVEDISKSEQ = 4;
Review Comment:
@Damans227
Thanks, agreed. This is also why I asked you about the configurations for
multiple CD-ROMs. We do need to consider these scenarios.
In my opinion, we don't need to consider the device ID changing when a VM is
stopped and started. Users should use the device UUID rather than the device
name inside the guest OS, since the device name (/dev/sdX) may change as ACS
orders the devices when the VM is started.
I think we should focus on preventing duplicate device IDs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
