bhouse-nexthop commented on code in PR #14207:
URL: https://github.com/apache/cloudstack/pull/14207#discussion_r4208606106
##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -5480,20 +5566,26 @@ private void
handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
return;
}
- if (PowerState.PowerOff.equals(vm.getPowerState())) {
+ // A missing report is not proof that the instance is gone, only
that the host did not list it. Stop it
+ // on the host before giving up its resources, otherwise a
still-running instance keeps its NICs and IP
+ // addresses while the database says they are free and they get
handed to another instance.
Review Comment:
Removed in 0d068391e5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
