bhouse-nexthop commented on code in PR #14207:
URL: https://github.com/apache/cloudstack/pull/14207#discussion_r4208614872
##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -696,6 +696,11 @@ protected void advanceExpunge(VMInstanceVO vm) throws
ResourceUnavailableExcepti
advanceStop(vm.getUuid(), VmDestroyForcestop.value());
vm = _vmDao.findByUuid(vm.getUuid());
+ // advanceStop() returns without contacting the host when the database
already has the instance as Stopped,
+ // Error, Destroyed or Expunging. The host may still be running it.
Expunging is about to release its
+ // addresses and delete its volumes, so make sure no domain is left
behind for it.
Review Comment:
Agreed, removed in 0d068391e5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
