slavkap opened a new pull request, #14389:
URL: https://github.com/apache/cloudstack/pull/14389

   ### Description
   
   This PR extends the import of unmanaged volumes capability to **StorPool** 
primary storage, and adds support for `importVm` from shared to work with 
StorPool primary storage as well.
   
   With this change:
   
   - Disk volumes that exist on a StorPool pool but are not yet tracked by 
CloudStack can be discovered and imported into CloudStack the same way volumes 
on other supported storage types already are.
   - `importVm` with `importSource=SHARED` now also works correctly for 
StorPool pools, so an existing VM's shared disk(s) on StorPool can be imported 
as part of VM import, not just standalone volumes.
   
   Once imported, a volume is fully managed by CloudStack: it participates in 
normal lifecycle operations and StorPool is kept informed of the change in 
ownership, so unmanaging it later correctly hands it back.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [X] Major
   - [ ] Minor
   
   
   ### How Has This Been Tested?
   Unit tests, Marvin integration tests, and manually verified `importVm` with 
`importSource=SHARED` against a VM with a
     StorPool volume; list/import and unmanage StorPool volumes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to