DaanHoogland commented on code in PR #14670:
URL: https://github.com/apache/cloudstack/pull/14670#discussion_r4540766345
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java:
##########
@@ -184,6 +192,10 @@ private void scaleKubernetesClusterVpcTierRules(final
List<Long> clusterVMIds) t
} catch (ResourceUnavailableException | NetworkRuleConflictException
e) {
throw new ManagementServerException(String.format("Failed to
activate SSH port forwarding rules for the Kubernetes cluster : %s",
kubernetesCluster.getName()), e);
}
+ if (vpcFirewallEnabled) {
+ // After the port forwarding rules, as when the cluster is created
+ addFirewallRulesForNodes(publicIp, clusterVMIds.size());
Review Comment:
@adestis-mf , you opened three issues;
> I'd prefer to keep this PR to the missing rules and fix the
import-then-scale case for both
> network types in
[#14673](https://github.com/apache/cloudstack/issues/14673), since it also
touches `removeSshFirewallRule`, which
> [#14165](https://github.com/apache/cloudstack/pull/14165) is changing. If
you'd rather have it here, I'll add it to this PR.
are you sugesting to solve all three in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
