adestis-mf commented on code in PR #14670:
URL: https://github.com/apache/cloudstack/pull/14670#discussion_r4541443214
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java:
##########
@@ -184,6 +192,10 @@ private void scaleKubernetesClusterVpcTierRules(final
List<Long> clusterVMIds) t
} catch (ResourceUnavailableException | NetworkRuleConflictException
e) {
throw new ManagementServerException(String.format("Failed to
activate SSH port forwarding rules for the Kubernetes cluster : %s",
kubernetesCluster.getName()), e);
}
+ if (vpcFirewallEnabled) {
+ // After the port forwarding rules, as when the cluster is created
+ addFirewallRulesForNodes(publicIp, clusterVMIds.size());
Review Comment:
No, this PR only fixes #14668: the missing firewall rules for CKS clusters
on VPC tiers when the VPC
has the Firewall service. The other two are separate:
- #14669 is not specific to CKS. It turned out to be the same problem as
#14146 (once a public IP of
a VPC tier has a firewall rule, further public IPs of the tier are no
longer added to the router)
and is fixed in #14681, which only changes `VpcVirtualRouterElement`.
- #14673 (scaling up a cluster with imported nodes) affects isolated
networks and VPC tiers
alike and touches `removeSshFirewallRule`, which #14165 changes, so I
would keep it for a separate
PR. If you prefer to have it here, I can add it to this PR.
Thanks for adding #14669 and #14673 to the 24.0 milestone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
