adestis-mf commented on code in PR #14670:
URL: https://github.com/apache/cloudstack/pull/14670#discussion_r4544736424
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java:
##########
@@ -184,6 +192,10 @@ private void scaleKubernetesClusterVpcTierRules(final
List<Long> clusterVMIds) t
} catch (ResourceUnavailableException | NetworkRuleConflictException
e) {
throw new ManagementServerException(String.format("Failed to
activate SSH port forwarding rules for the Kubernetes cluster : %s",
kubernetesCluster.getName()), e);
}
+ if (vpcFirewallEnabled) {
+ // After the port forwarding rules, as when the cluster is created
+ addFirewallRulesForNodes(publicIp, clusterVMIds.size());
Review Comment:
An update on the import-then-scale case: #14673 turned out to be a duplicate
of #12633, and a fix is proposed in #14683. It targets `4.22`, where the bug
exists for isolated networks, and it leaves `removeSshFirewallRule` unchanged,
so it does not conflict with #14165.
The VPC tier path of this PR is not in `4.22`. Once #14683 is merged forward
to `main`, I'll call the same method (`removeExternalNodeSshRules`) in
`scaleKubernetesClusterVpcTierRules` here, so that VPC tiers with the Firewall
service are covered as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
