syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r130694606
##########
File path:
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxySecureServerFactoryImpl.java
##########
@@ -105,6 +122,87 @@ public void configure(HttpsParameters params) {
}
@Override
+ public Server createConsoleProxyServer(int port) throws IOException {
+
+ Server server = getServerWithContext(port);
+
+ /**
+ * add all context here
+ **/
+
+ // HTTP Configuration
+ HttpConfiguration http = new HttpConfiguration();
+ http.addCustomizer(new SecureRequestCustomizer());
+
+ // Configuration for HTTPS redirect
+ http.setSecurePort(443);
Review comment:
Make sure you move any hard coded configuration to a static final config
variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
