syed commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding
Support for NoVNC Console for KVM
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r130693009
##########
File path:
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java
##########
@@ -379,7 +359,23 @@ private static void startupHttpCmdPort() {
}
}
- public static void main(String[] argv) {
+ private static void startServerForNoVNC() {
+ try {
+ ConsoleProxyServerFactory factory = getHttpServerFactory();
+ if (factory == null) {
+ s_logger.error("Unable to load HTTP server factory");
+ System.exit(1);
+ }
+ Server webServer = factory.
+ createConsoleProxyServer(443);
Review comment:
You don't need the function `createConsoleProxyServer` re-use the function
`factory.createHttpServerInstance`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
