DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993:
Securing Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134700719
##########
File path:
server/src/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -125,6 +137,73 @@ public boolean processTimeout(long agentId, long seq) {
return false;
}
+ private void setupAgentSecurity(final Connection sshConnection, final
String agentIp, final String agentHostname) {
Review comment:
rather big method. Can we split in keystore setup, certificate creation,
certificate loading?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
