DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993:
Securing Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134400617
##########
File path: agent/src/com/cloud/agent/Agent.java
##########
@@ -166,7 +178,8 @@ public Agent(final IAgentShell shell, final int
localAgentId, final ServerResour
throw new ConfigurationException("Unable to configure " +
_resource.getName());
}
- _connection = new NioClient("Agent", _shell.getHost(),
_shell.getPort(), _shell.getWorkers(), this);
+ final String host = _shell.getHost();
Review comment:
This final seems strange, as we intend to loop over adresses, right? (I
might be mixing things up here, please do tell)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
