nvazquez commented on a change in pull request #2295: CLOUDSTACK-10109: Enable
dedication of public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#discussion_r147038497
##########
File path: server/src/com/cloud/api/ApiResponseHelper.java
##########
@@ -735,13 +740,28 @@ public VlanIpRangeResponse
createVlanIpRangeResponse(Class<? extends VlanIpRange
vlanResponse.setPhysicalNetworkId(pnw.getUuid());
}
}
+ vlanResponse.setForSystemVms(getIsForSystemVms(vlan.getId()));
vlanResponse.setObjectName("vlan");
return vlanResponse;
} catch (InstantiationException | IllegalAccessException e) {
throw new CloudRuntimeException("Failed to create Vlan IP Range
response", e);
}
}
+ /**
+ * Return true if vlan IP range is dedicated for system vms (SSVM and
CPVM), false if not
+ * @param vlanId vlan id
+ * @return true if VLAN IP range is dedicated to system vms
+ */
+ private boolean getIsForSystemVms(long vlanId){
Review comment:
Done, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
