nvazquez commented on a change in pull request #2295: CLOUDSTACK-10109: Enable 
dedication of public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#discussion_r147038982
 
 

 ##########
 File path: ui/scripts/system.js
 ##########
 @@ -85,22 +91,42 @@
                         success: function (json) {
                             var domain = json.listdomainsresponse.domain[0];
 
+                            if (data.forSystemVms != null) {
+                                systemvms = '<li>' + _l('label.system.vms') + 
': ' + data.forSystemVms + '</li>'
 
 Review comment:
   Actually that refactoring will show only `true` or `false` in the UI, 
without knowing what would be it refered to. Please see last screenshot on PR 
description

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to