rafaelweingartner commented on a change in pull request #2315: A comprehensive solution for #CLOUDSTACK-9025. URL: https://github.com/apache/cloudstack/pull/2315#discussion_r150219446
########## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ########## @@ -58,7 +59,9 @@ import com.cloud.vm.dao.UserVmDao; public class XenServerGuru extends HypervisorGuruBase implements HypervisorGuru, Configurable { - private final Logger LOGGER = Logger.getLogger(XenServerGuru.class); + + private Logger logger = Logger.getLogger(getClass()); Review comment: The result is the same. The variable was not declared as "static", but its name was LOGGER as a static variable. I only changed because at first I removed it as it was not being used. Then, when I added some logs, I re-added the variable and I created this way. I can change to static final. I can change to static if you think it is better for some reason. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services